feature(salesforce-sink): Add, update, and delete salesforce sink #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pending: add secrets to Github and make the secrets load properly on the tests. |
|
@christophd can you help me with the secrets? |
oscerd
approved these changes
Mar 28, 2022
lburgazzoli
reviewed
Mar 28, 2022
lburgazzoli
reviewed
Mar 28, 2022
|
Disabled tests directly to salesforce api to prevent problems if the api is down. |
lburgazzoli
reviewed
Mar 29, 2022
lburgazzoli
reviewed
Mar 29, 2022
lburgazzoli
reviewed
Mar 29, 2022
Delawen
force-pushed
the
salesforce-sink
branch
2 times, most recently
from
55659b6
to
d1f0d7b
Compare
|
The failed test is not related to this PR... |
|
Should I maybe rebase? Or is it flaky tests and will be the same? |
|
It's not failing on other PRs. |
|
Let's try to rebase. |
Also, improved documentation on all salesforce sink
Delawen
force-pushed
the
salesforce-sink
branch
from
d1f0d7b
to
0b973b4
Compare
|
after the rebase the test is green, YAY! this Kafka test has been flaky before (~50% failing) but I think I have fixed some issues with it. as @oscerd has mentioned the test is stable on other PRs. So lets's keep an eye on that one as it may still be flaky (maybe ~10%). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.